Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter common props from the data picker #4905

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Filter common props from the data picker #4905

merged 4 commits into from
Feb 15, 2024

Conversation

bkrmendy
Copy link
Contributor

Problem

Props like style, css or className can clutter up the data picker

Fix

Filter out those props from the data picker. The filtering is implemented in a somewhat generic way to make it easy to tweak this filtering logic

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Feb 15, 2024

Job #10454: Bundle Size — 62.15MiB (~+0.01%).

6937c9b(current) vs d299c8d master#10453(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10454		      Baseline
Job #10453
Regression  Initial JS 35.2MiB(~+0.01%) 35.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.35% 0%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4359 4359
No change  Duplicate Modules 494 494
No change  Duplicate Code 30.8% 30.8%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10454		      Baseline
Job #10453
Regression  JS 62.14MiB (~+0.01%) 62.14MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10454 report View feature/filter-common-props branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@bkrmendy bkrmendy merged commit bf057b8 into master Feb 15, 2024
17 checks passed
@bkrmendy bkrmendy deleted the feature/filter-common-props branch February 15, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@ruggi ruggi ruggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrmendy @ruggi @balazsbajorics